-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cipher list option to IMAP config flow #91896
Add cipher list option to IMAP config flow #91896
Conversation
Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, did not recognized this in my previous review
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@MartinHjelmare are you happy with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Proposed change
Add cipher list option to IMAP config flow. The new option allows to set an alternative cipherlist.
The PR has the same base as #91078.
The new option allows to select the list of SSL ciphers to be accepted from this endpoint.
default
(system default),modern
orintermediate
(inspired by Mozilla Security/Server Side TLS).The option will only show up if advanced mode is enabled within the user context.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: