Set sidebar title to location name #23779
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @sethvargo
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
I believe location_name is always initialized by default for everyone as "Home". So this is going to change the sidebar for everyone. |
|
@karwosts would it be better to:
|
This sets the sidebar title to the location_name configuration value. If no name is present, it defaults back to "Home Assistant". As someone with multiple HomeAssistant installations, I find this very helpful to quickly differentiate which instance I'm looking at in the UI. I've been using a HACS add-on for this, but having first-class support feels useful.
sethvargo
force-pushed
the
sethvargo/location_name
branch
from
7f20bf6 to
981218f
Compare
wendevlin
added
the
Needs UX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Set the sidebar title to the
location_nameconfiguration value. If no name is present, it defaults back to "Home Assistant". As someone with multiple HA installations, I find this very helpful to quickly differentiate which instance I'm looking at in the UI. I've been using a HACS add-on for this, but having first-class support feels useful.Type of change
Example configuration
N/A - this default configuration will work.
Additional information
An alternative approach I considered was to introduce a new configuration parameter for the sidebar title, but that felt unnecessary since most of the time the value will be the location_name of the HA instance.
Checklist
The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed: