Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce backup switch when updating core and addons #23814

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 20, 2025

Proposed change

Core PR:

Re-introduce the backup switch when updating core or an addon :

  • in the more info
  • in the addon page

Trigger automatic backup when updating core

CleanShot 2025-01-20 at 17 13 41

Create "add-on" backup when updating add-on (more info)

CleanShot 2025-01-20 at 17 13 19

Create "add-on" backup when updating add-on (add-on page)

CleanShot 2025-01-20 at 18 28 52

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Supervisor Related to the supervisor panel label Jan 20, 2025
@piitaya piitaya changed the title Reintroduce backup switch when updating Reintroduce backup switch when updating core and addons Jan 20, 2025
@piitaya piitaya marked this pull request as ready for review January 21, 2025 08:57
@piitaya piitaya added the Backend Change Required Requires a Backend Core Code Change label Jan 21, 2025
@piitaya piitaya force-pushed the reintroduce_backup_switch_more_info branch from 211569f to 76594b0 Compare January 21, 2025 11:00
src/translations/en.json Outdated Show resolved Hide resolved
src/data/update.ts Outdated Show resolved Hide resolved
@piitaya piitaya force-pushed the reintroduce_backup_switch_more_info branch from 76594b0 to fa38441 Compare January 21, 2025 13:52
wendevlin
wendevlin previously approved these changes Jan 21, 2025
@piitaya piitaya force-pushed the reintroduce_backup_switch_more_info branch from 8b5efbb to 6f05010 Compare January 22, 2025 14:18
@piitaya piitaya added wait for backend and removed Backend Change Required Requires a Backend Core Code Change labels Jan 22, 2025
@MartinHjelmare
Copy link
Member

Core PR is approved.

@silamon silamon added backend merged The backend PR for this frontend PR has been merged and removed backend merged The backend PR for this frontend PR has been merged labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants