Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include last 30 min and 2 hours into history page #23848

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

tasomaniac
Copy link

@tasomaniac tasomaniac commented Jan 22, 2025

Breaking change

No

Proposed change

The change adds last 30 min and 2 hours options. Based on the feedback on this PR, I can amend to include other options.

Screenshots

The time of the computer was 9:11 PM when this was taken.

image image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Improvement of existing feature

Example configuration

N/A

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works (couldn't find existing tests, let me know if they exist and I will add more to cover the new options)

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tasomaniac

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added cla-needed WTH Issues & PRs generated from the "Month of What the Heck?" cla-recheck cla-signed and removed cla-recheck cla-needed labels Jan 22, 2025
@tasomaniac tasomaniac marked this pull request as ready for review January 22, 2025 20:13
@tasomaniac

This comment has been minimized.

@silamon
Copy link
Contributor

silamon commented Jan 25, 2025

There's a related PR in the queue: #23362. I'll link it up here for visibility.
What's the reasoning to add 30 minutes and 2 hours specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants