Restore Bluetooth configuration panel #23877
Conversation
...panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard-router.ts
Outdated
Show resolved
Hide resolved
| <ha-card | ||
| .header=${this.hass.localize( | ||
| "ui.panel.config.bluetooth.settings_title" | ||
| )} | ||
| > | ||
| <div class="card-actions"> | ||
| <mwc-button @click=${this._openOptionFlow} | ||
| >${this.hass.localize( | ||
| "ui.panel.config.bluetooth.option_flow" | ||
| )}</mwc-button | ||
| > | ||
| </div> | ||
| </ha-card> |
There was a problem hiding this comment.
That's a bit up to you, but if you want people to end up here during troubleshooting, which was a use-case I had in mind, then we don't need to show this card. (You can visit /config/bluetooth without providing a config flow, where /config/bluetooth will act as a bluetooth hub.)
There was a problem hiding this comment.
Is there a way to reach it without manually typing in the URL? If they have to type it in it's much more likely we will never get them to do it and the issue report will never get solved. We have such a hard time getting debug logs and diagnostics, I want it to be as frictionless as possible to get here.
There was a problem hiding this comment.
https://my.home-assistant.io/ links can be added to the documentation page.
There was a problem hiding this comment.
I think that would limit discoverability as it would make it a lot harder to find. I have limited success getting people to click my links when working issues (reading the whole Bluetooth docs as well)
There was a problem hiding this comment.
The only place where they are being taken to the integration panel, is through the configure button on the config flow. What would be the ultimate solution?
There was a problem hiding this comment.
KNX is the best example that comes to mind first.
Quick search brings Insteon, Dynalite and lcn as well.
There was a problem hiding this comment.
As a side note, since it's a built-in panel, you may need to use frontend.async_register_built_in_panel instead of panel_custom.async_register_panel.
There was a problem hiding this comment.
I'm a bit on the fence since there's 100s of thousands of people who are suddenly gonna get a Bluetooth panel. It's a really tough call because we wanna make it easy for them to find their devices, but we also don't wanna overwhelm them with information.
There was a problem hiding this comment.
The other API's I'm planning on adding our config entry/adapter specific so we would still need a screen for each adapter.
There was a problem hiding this comment.
having just a URL will make it too hard to be discoverable. I suggest we do use the "configure" from the config entry to go to the bluetooth panel, as we do for Zigbee, Z-Wave, Matter and KNX. And then on the bluetooth panel, have a button to open the options flow for that config entry, that way no options are lost.
...panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard-router.ts
Outdated
Show resolved
Hide resolved
...panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard-router.ts
Outdated
Show resolved
Hide resolved
...panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard-router.ts
Outdated
Show resolved
Hide resolved
…uetooth-config-dashboard-router.ts
| const searchParams = new URLSearchParams(window.location.search); | ||
| if (this._configEntry && !searchParams.has("config_entry")) { | ||
| searchParams.append("config_entry", this._configEntry); | ||
| navigate( | ||
| `${this.routeTail.prefix}${this.routeTail.path}?${searchParams.toString()}`, | ||
| { replace: true } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Is there a reason for this code to still exist?
There was a problem hiding this comment.
I think this can be trimmed down more. Let me check
There was a problem hiding this comment.
trimmed it back down in 1bd0a2b
Proposed change
Restores the panel that was disabled in #23830 and add router so the options flow can still be accessed.
The next iteration (future PR) will add information about the connection slots once home-assistant/core#136215 is finished
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: