-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flux: document how the "mired" mode actually sets kelvin #36808
base: current
Are you sure you want to change the base?
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Since home-assistant/core#132839 the Flux integration is using the value in kelvin to set the light temperature. Let's reflect this in the documentation while preserving existing installations.
📝 WalkthroughWalkthroughThe pull request involves a minor documentation update for the Flux integration in Home Assistant. The change clarifies the description of the Changes
No sequence diagram is necessary for this documentation update, as it does not introduce any new functionality or change in system behavior. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Since home-assistant/core#132839 the Flux integration is using the value in kelvin to set the light temperature.
Let's reflect this in the documentation while preserving existing installations.
Proposed change
As Home Assistant is switching to kelvin over mired, some components still refer to mired. I know Flux is not the most popular integration, but as someone who is starting to equip with smart lights, automatic colour temperature and brightness (aka circadian lighting) was one of my main motivations.
I started with modifying the Flux integration itself, but then found the change was trivial and kind of useless, as the code works the same, whether the mode is "mired", "kelvin", or even "foobar" if that value was allowed.
So I thought it's more a matter of adjusting the documentation than bothering the core repository with yet another PR to review.
I can still push my PR to core if you want to go the long way and actually add "kelvin" as a possible configuration value. Or do it yourself, which will probably be faster than reviewing me doing so.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
flux
integration to clarify thatmired
is an alias forkelvin
in themode
configuration option.