Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the issue #84.
Problems solved:
One left inconsistency between Android and iOS is that:
Seems to me, that happens because the navigator always request the location of the newly attached fragment in: HotwireWebFragmentDelegate.kt#328
Not sure how to proceed here.
Another thing is, that the app previously freezed when the modal was popped through /recede_historical_location on the first fragment (as mentioned in the issue). I've fixed that by setting
shouldNavigate
to false, if we are popping a fragment.But i guess it could be worth to investigate more, why the app freezed in the first place.