You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given that these lines of code are exclusive to the domain of R and this package, it would make more sense for a function to be written from these lines of code.
The function should do the following:
Take in a vector of hubs and a path to an output file
for each hub:
i. run validate_hub_config() and, if necessary, view_config_val_errors()
ii. append a report to the output file
iii. return github error on failure
return TRUE if all configuration files are valid
This way, we would be able to reduce the maintenance burden on the validate-hub-config workflow files, which is especially important given that they are distributed and not centrally controlled (and fixing bugs in this context is not easy: https://github.com/zkamvar/2022-10-20-workflow-bug).
From here, the workflow could look something like this after this is implemented:
This originally stems from hubverse-org/hubverse-actions#9 where I and @annakrystalli implemented a fix in hubverse-org/hubverse-actions#20 that involves more than 20 lines of R code inside a GitHub workflow.
Given that these lines of code are exclusive to the domain of R and this package, it would make more sense for a function to be written from these lines of code.
The function should do the following:
i. run
validate_hub_config()
and, if necessary,view_config_val_errors()
ii. append a report to the output file
iii. return github error on failure
TRUE
if all configuration files are validThis way, we would be able to reduce the maintenance burden on the
validate-hub-config
workflow files, which is especially important given that they are distributed and not centrally controlled (and fixing bugs in this context is not easy: https://github.com/zkamvar/2022-10-20-workflow-bug).From here, the workflow could look something like this after this is implemented:
The text was updated successfully, but these errors were encountered: