-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ci_validate_hub_config()
function
#37
Conversation
ci_validate_hub_config()
function 31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Thanks for this nice addition!
Made some comments and requests for changes. Happy to discuss any points.
Co-authored-by: Anna Krystalli <[email protected]>
Based on comments from @annakrystalli
ci_validate_hub_config()
function 31ci_validate_hub_config()
function
Ready for your review, @annakrystalli, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and good to see you won your battle with cLINT EsatWooOD 😆
This adds the exported function
ci_validate_hub_config()
. It will replace 24 lines of R code embedded in YAML with a single call:hubAdmin::ci_validate_hub_config()
.It will not show up in the default user manual because I've added the
internal
keyword to its documentation.This will fix #31
The new steps for the validate-config action would look like this: