upgrade schema version to v5.0.0 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annakrystalli
changed the base branch from
main
to
ak/1-target-key-value-pair/89
zkamvar
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
This looks good to me, thank you!
Note: I have not yet made use of the new functionality in hubUtils for using local schema as the latest schema in hubUtils is currently v4.0.0 and would need a PR to hubUtils first.
Technically, because hubverse-org/hubUtils#194 is on the main branch, this PR is actually using the updated version.
I reckon we can just update hubUtils straight to v5.0.0 on the main branch once it's merged instead of first to the dev branch and then to main
The branch protection rules will prevent us from doing that (for good reason: if the new schema borks hubUtils, then we need to rethink), but myself or @elray1 or anyone can do a rubber-stamp review for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build on #90 but changes all mention of v4.0.1 to v5.0.0.
I've also incorporated comments from the review in #90
I'm opening the PR against the previous PR so you don't have to review the whole thing again and just focus on the changes related to bumping the schema to v5.0.0. I've ran the tests locally and by pointing to
mainfirst though and all tests pass. When I merge this into #90 I'll also make sure to re-run the tests before merging.Note: I have not yet made use of the new functionality in
hubUtilsfor using local schema as the latest schema inhubUtilsis currently v4.0.0 and would need a PR tohubUtilsfirst. I reckon we can just updatehubUtilsstraight to v5.0.0 on the main branch once it's merged instead of first to the dev branch and then to main