Only show a single target_keys key value pair to conform to v4.0.1 schema #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elray1
reviewed
Jan 6, 2025
There was a problem hiding this comment.
these changes look good to me. I'm commenting rather than approving for the same reasons outlined in this comment.
zkamvar
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #226
When we began thinking about target metadata, we allowed for target keys to be able to span multiple columns. We have now decided that this represents unnecessary complexity that is not being used. This is now reflected in (under development) schema version v5.0.0 hubverse-org/schemas#118
The hubDocs documentation should now also reflect this.
This PR is related to hubverse-org/schemas#119 and: