-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deep link to Local Chat #1055
base: main
Are you sure you want to change the base?
Add deep link to Local Chat #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @DePasqualeOrg 🔥
mainTask: "text-generation", | ||
displayOnModelPage: (model) => isMlxModel(model), | ||
deeplink: (model) => | ||
new URL(`https://localchat.co/model/${model.id}`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new URL(`https://localchat.co/model/${model.id}`), | |
new URL(`localchat://model/${model.id}`), |
Shouldn't this be this? So that people get a directly deeplinked to the App?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This route on localchat.co is a universal link that will open the model in app if the app is installed on the user's device. If the app is not installed, it will show a page with a link to download the app, which uses a "referral" search parameter to open the model in the app after it has been downloaded. And as a fallback, there is also a button on the page to open the model in the app if the app is installed.
btw do you have an SVG for the logo? :) |
I don't have an SVG, but you can find a PNG here. Would that work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool app! just installed it (on iPhone) to try it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool contribution as usual, @DePasqualeOrg, thanks a lot! 🙌
Co-authored-by: Pedro Cuenca <[email protected]>
I'd love to get this merged. Is there anything else I need to do on my end? |
My macOS and iOS app Local Chat runs text generation models from the MLX Community. I've added the ability to deep link to models in the app.