Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep link to Local Chat #1055

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

DePasqualeOrg
Copy link

My macOS and iOS app Local Chat runs text generation models from the MLX Community. I've added the ability to deep link to models in the app.

@coyotte508 coyotte508 requested a review from Vaibhavs10 December 3, 2024 09:53
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DePasqualeOrg 🔥

mainTask: "text-generation",
displayOnModelPage: (model) => isMlxModel(model),
deeplink: (model) =>
new URL(`https://localchat.co/model/${model.id}`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new URL(`https://localchat.co/model/${model.id}`),
new URL(`localchat://model/${model.id}`),

Shouldn't this be this? So that people get a directly deeplinked to the App?

Copy link
Author

@DePasqualeOrg DePasqualeOrg Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This route on localchat.co is a universal link that will open the model in app if the app is installed on the user's device. If the app is not installed, it will show a page with a link to download the app, which uses a "referral" search parameter to open the model in the app after it has been downloaded. And as a fallback, there is also a button on the page to open the model in the app if the app is installed.

@Vaibhavs10
Copy link
Member

btw do you have an SVG for the logo? :)

@DePasqualeOrg
Copy link
Author

I don't have an SVG, but you can find a PNG here. Would that work?

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool app! just installed it (on iPhone) to try it

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool contribution as usual, @DePasqualeOrg, thanks a lot! 🙌

packages/tasks/src/local-apps.ts Outdated Show resolved Hide resolved
@DePasqualeOrg
Copy link
Author

I'd love to get this merged. Is there anything else I need to do on my end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants