Add TabPFN as library #1094
Add TabPFN as library #1094
Conversation
merveenoyan
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
|
@pcuenca can you briefly review? |
| repoName: "TabPFN", | ||
| repoUrl: "https://github.com/PriorLabs/TabPFN", | ||
| filter: false, | ||
| countDownloads: `path_extension:"ckpt"`, |
There was a problem hiding this comment.
| countDownloads: `path_extension:"ckpt"`, | |
| countDownloads: `path_extension:"ckpt" or path:"config.json"`, |
maybe?
There was a problem hiding this comment.
@merveenoyan @pcuenca Sorry bringing this back up on a closed PR but doing this will double-count downloads since both the ckpt and the config.json files are downloaded (or attempted to be downloaded) in the download process. See https://github.com/PriorLabs/TabPFN/blob/faf092b49b255f0e68270947eeeca4817b0013d4/src/tabpfn/model/loading.py#L143.
What I would do is to remove this line which will default to the default counting rule which is "count on config.json downloads".
There was a problem hiding this comment.
Actually, this PR has been merged but is not effective on the Hub because models are tagged as TabPFN instead of tabpfn (I'll open PRs to fix this). But if you look at https://huggingface.co/models?other=tabpfn the download count is already there => it defaulted to counting config.json which is correct.
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
|
@pcuenca I sent them an email on how to do that in their codebase so the models are automatically downloaded and loaded through Hub when model id is given. Will wait on their reply before doing that. |
|
Thank you @merveenoyan and @pcuenca for being super responsive 🙏! |
|
Be careful that tags are case-sensitive so models should be tagged as (nit) In general, better to check that https://huggingface.co/models?other=tabpfn is correctly populated before merging this kind of PR. |
…on download) See #1094 (comment). Better to count only `config.json` downloads to avoid double-counting. Also, it seems that it should be easy to create a "use this model" snippet for TabPFN models. As mentioned by @merveenoyan in #1094 (comment), documenting it in TabPFN repos + on the Hub will make it easier to load the models for end users. This is orthogonal to this PR though.
|
Thanks @Wauplin, sorry for the hasty merge. |
…downloads) (#1100) See #1094 (comment). Better to count only `config.json` downloads to avoid double-counting. Also, it seems that it should be easy to create a "use this model" snippet for TabPFN models. As mentioned by @merveenoyan in #1094 (comment), documenting it in TabPFN repos + on the Hub will make it easier to load the models for end users. This is orthogonal to this PR though. cc @noahho
The authors of TabPFN want to track the model (it's being downloaded a lot on GH it seems but not as much on Hub because they track config) @pcuenca