-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dotenv #59
base: master
Are you sure you want to change the base?
Conversation
ping @hughsk, would love to see this in since I'm currently using this to build my production app 🙈 😄 |
ping @hughsk / @yoshuawuyts, happy to receive feedback |
Started using @LinusU branch also. I will notify from my side when i get some problems. |
ping @hughsk / @yoshuawuyts, happy to receive feedback |
Used it 4 months and no issues. |
ping @hughsk / @yoshuawuyts, happy to receive feedback |
@LinusU This module is considered feature-complete, which means adding more features isn't within the scope of the project. We should probably write a note about that somewhere though. Pretty much the only patches that would be accepted at this point are to fix bugs with versions of browserify, or other incompatibility issues. It would probably be best to release a separate module for dotenv support. Thanks! |
This PR adds support for loading a
.env
(dotenv) file containing additional environmental variables. It's super useful when you have multiple projects since it allows you to keep your environment contained to each project instead of having it global.The file will only be loaded when the
dotenv
flag is passed, and variables from the file will only be used if they aren't already specified elsewhere which is how the dotenv package usually works when loading it straight into process.env.I tried to follow the existing code style, please let me know if you need anything more. Thanks 👋