Skip to content

Commit

Permalink
Improve NOTES.txt + bump version to 0.7.9
Browse files Browse the repository at this point in the history
  • Loading branch information
hugoprudente committed Mar 6, 2021
1 parent 0741d8a commit 2d2ca20
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions incubator/foundry-vtt/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: foundry-vtt
description: Foundry Virtual Tabletop
type: application
version: 0.2.3
appVersion: 0.7.7
version: 0.2.4
appVersion: 0.7.9
keywords:
- game
- server
Expand Down
16 changes: 8 additions & 8 deletions incubator/foundry-vtt/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
1. Get the application URL by running these commands:
{{- if .Values.ingress.enabled }}
{{- range $host := .Values.ingress.hosts }}
{{- range .paths }}
http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $host.host }}{{ . }}
{{- end }}
{{- end }}
http{{ if $.Values.ingress.tls }}s{{ end }}://{{ .Values.ingress.hostname }}
{{- else if contains "NodePort" .Values.service.serviceType }}
export NODE_PORT=$(kubectl get --namespace {{ .Release.Namespace }} -o jsonpath="{.spec.ports[0].nodePort}" services {{ include "foundry-vtt.fullname" . }})
export NODE_IP=$(kubectl get nodes --namespace {{ .Release.Namespace }} -o jsonpath="{.items[0].status.addresses[0].address}")
Expand All @@ -16,6 +12,10 @@
echo http://$SERVICE_IP:{{ .Values.service.port }}
{{- else if contains "ClusterIP" .Values.service.serviceType }}
export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "foundry-vtt.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}")
echo "Visit http://127.0.0.1:8080 to use your application"
kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 8080:80
{{- end }}
echo "Visit http://127.0.0.1:30000 to use your application"
kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 8080:30000
{{- end }}

2. If you like this Helm Chart please consider Start it on GitHub.com

3. Enjoy and may you roll the best that you can!
2 changes: 1 addition & 1 deletion incubator/foundry-vtt/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
image:
pullPolicy: Always
repository: <add-your-private-image-repo-here>

This comment has been minimized.

Copy link
@a1994sc

a1994sc Mar 23, 2021

Should this be not a placeholder repository?

This comment has been minimized.

Copy link
@hugoprudente

hugoprudente Mar 31, 2021

Author Owner

We can add it, I let it explicit just to avoid people trying to use something that doesn't exist.

tag: 0.7.7
tag: 0.7.9

# Credentials for Docker private repository.
imagePullSecrets: []
Expand Down

0 comments on commit 2d2ca20

Please sign in to comment.