Update logger.ts #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest add more strict typeification. I have replaced 'any' with 'unknown' type
|
@nikbenesh is attempting to deploy a commit to the Abacus Works Team on Vercel. A member of the Team first needs to authorize it. |
|
@nikbenesh Thanks for the PR but as you can see, 3 of the CI tests are failing. This tells me that you didn't build and run the app after making changes. In the future, please thoroughly test your changes before submitting PRs. I'll keep this one open in case you want to keep working on it but I'm not sure there's much benefit to tweaking the types in Logger for now. If you'd like a different task to take on, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest add more strict typeification. I have replaced 'any' with 'unknown' type