Update inpage-metamask.js #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some error handling for better safety
|
@nikbenesh is attempting to deploy a commit to the Abacus Works Team on Vercel. A member of the Team first needs to authorize it. |
jmrossy
reviewed
Dec 21, 2024
Comment on lines
-1
to
-2
| // Copied from https://github.com/WalletConnect/web3modal/pull/614/files | ||
| // But updated to use newer packages |
There was a problem hiding this comment.
This comment was kept intentionally, this is useful information
Comment on lines
+6
to
+8
| const isMetaMaskAvailable = () => { | ||
| return typeof window !== 'undefined' && (window.ethereum || window.web3); | ||
| }; |
There was a problem hiding this comment.
This code isn't used anywhere else, why pull it out into a function?
| shouldShimWeb3: true, | ||
| }); | ||
| } catch (error) { | ||
| console.error('Failed to initialize MetaMask provider:', error); |
There was a problem hiding this comment.
this app's convention is to use logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some error handling for better safety