DO NOT MERGE: zksync deploy branch #4761
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pbio <[email protected]>
Signed-off-by: pbio <[email protected]>
Signed-off-by: pbio <[email protected]>
Signed-off-by: pbio <[email protected]>
Signed-off-by: pbio <[email protected]>
Signed-off-by: pbio <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
### Description 1. correctly generate core config for zksync chains - copied from `pb/zksync` https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/pb/zksync/typescript/infra/config/environments/mainnet3/core.ts - note the storage aggregation ism was not around when doing the first zksync chain deploys, and we haven't gone back and updated the config generation yet to include this - required so we infer the correct config for zksync changes and don't assume it's the same as non-zksync chains 2. update ISM reader to return storagemultisigism types on zksync - since static ISMs are not supported on zksync - the moduleType is the same, so the reader has to determine if it's static/storage - note: at the moment on non-zksync we assume it's a static multisig/aggregation ISM - required so we correctly compare the config vs onchain config ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing - these changes were used to verify SAFE txs for the last couple of batches - the config changes have also been used in production on zksync chains since October 23rd 2024 [`26d198a` (#4761)](26d198a#diff-d4db62438f3fd9acf24be52093e81d126292859f9f48c81aa1704d41fe8ddf1a)
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description - deploy to abstracttestnet, treasuretopaz - standard deployments from this branch - zksync deployments themselves done from hyperlane-xyz#4761 ### Drive-by changes - testnet igp - fix validator announce script, should only be skipping `lumia` ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing manual --------- Signed-off-by: pbio <[email protected]>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description 1. correctly generate core config for zksync chains - copied from `pb/zksync` https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/pb/zksync/typescript/infra/config/environments/mainnet3/core.ts - note the storage aggregation ism was not around when doing the first zksync chain deploys, and we haven't gone back and updated the config generation yet to include this - required so we infer the correct config for zksync changes and don't assume it's the same as non-zksync chains 2. update ISM reader to return storagemultisigism types on zksync - since static ISMs are not supported on zksync - the moduleType is the same, so the reader has to determine if it's static/storage - note: at the moment on non-zksync we assume it's a static multisig/aggregation ISM - required so we correctly compare the config vs onchain config ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing - these changes were used to verify SAFE txs for the last couple of batches - the config changes have also been used in production on zksync chains since October 23rd 2024 [`26d198a` (hyperlane-xyz#4761)](hyperlane-xyz@26d198a#diff-d4db62438f3fd9acf24be52093e81d126292859f9f48c81aa1704d41fe8ddf1a)
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description - deploy to abstracttestnet, treasuretopaz - standard deployments from this branch - zksync deployments themselves done from hyperlane-xyz#4761 ### Drive-by changes - testnet igp - fix validator announce script, should only be skipping `lumia` ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing manual --------- Signed-off-by: pbio <[email protected]>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description 1. correctly generate core config for zksync chains - copied from `pb/zksync` https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/pb/zksync/typescript/infra/config/environments/mainnet3/core.ts - note the storage aggregation ism was not around when doing the first zksync chain deploys, and we haven't gone back and updated the config generation yet to include this - required so we infer the correct config for zksync changes and don't assume it's the same as non-zksync chains 2. update ISM reader to return storagemultisigism types on zksync - since static ISMs are not supported on zksync - the moduleType is the same, so the reader has to determine if it's static/storage - note: at the moment on non-zksync we assume it's a static multisig/aggregation ISM - required so we correctly compare the config vs onchain config ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing - these changes were used to verify SAFE txs for the last couple of batches - the config changes have also been used in production on zksync chains since October 23rd 2024 [`26d198a` (hyperlane-xyz#4761)](hyperlane-xyz@26d198a#diff-d4db62438f3fd9acf24be52093e81d126292859f9f48c81aa1704d41fe8ddf1a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
too many
Related issues
Backward compatibility
Testing
manual