feat: add the # of messages prioritized in the queue to the http resp… #5043
+403
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kamiyaa
commented
Dec 18, 2024
kamiyaa
commented
Dec 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5043 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
kamiyaa
force-pushed
the
message-retry
branch
from
e234faf to
b35d465
Compare
kamiyaa
force-pushed
the
message-retry
branch
from
b35d465 to
cf9c2c4
Compare
tkporter
reviewed
Dec 21, 2024
- also updating tracing calls to use structured logs - update variable names to receiver/transmitter instead of rx/tx
- this creates a nice separation between each retry request and won't cause multiple requests to conflict with each others responses
kamiyaa
force-pushed
the
message-retry
branch
from
e23f01a to
491f981
Compare
daniel-savu
reviewed
Dec 23, 2024
- add more logging - move test code into helper functions
- log matched request uuids
daniel-savu
reviewed
Dec 30, 2024
- update test cases to (1, 1) - add error handling - panic if failed to send retry request
daniel-savu
approved these changes
Jan 2, 2025
|
🙏 go @kamiyaa! You need to fix clippy for CI to pass btw: |
Ah, let me do that before merging! |
tkporter
reviewed
Jan 3, 2025
- fix nits - add comments to functions - remove thread::spawn
tkporter
approved these changes
Jan 6, 2025
tkporter
reviewed
Jan 9, 2025
| if retry_req.pattern.op_matches(&op) { | ||
| debug!(uuid = retry_req.uuid, "Matched request"); | ||
| retry_response.matched += 1; | ||
| Some(retry_req.uuid.clone()) |
There was a problem hiding this comment.
seems like this isn't used anymore? think we can go back to using .any instead of filter_map and avoid this allocation
|
|
||
| // This channel is only created to service this single | ||
| // retry request so we're expecting a single response | ||
| // from each transmitter end, hence we are using a channel of size 1 |
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
hyperlane-xyz#5043) ### Description Add a mpsc channel between relayer and message retry handler, so message retry handler knows the retry results from the relayer. `POST /message_retry` endpoint now returns a JSON with details on the retry request: ```rust #[derive(Clone, Debug, Deserialize, Serialize)] pub struct MessageRetryResponse { /// ID of the retry request pub uuid: String, /// how many pending operations were processed pub processed: usize, /// how many of the pending operations matched the retry request pattern pub matched: u64, } ``` ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues Fixes hyperlane-xyz#4059 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing Updated unit tests to return a response so the handler is not blocked
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
hyperlane-xyz#5043) ### Description Add a mpsc channel between relayer and message retry handler, so message retry handler knows the retry results from the relayer. `POST /message_retry` endpoint now returns a JSON with details on the retry request: ```rust #[derive(Clone, Debug, Deserialize, Serialize)] pub struct MessageRetryResponse { /// ID of the retry request pub uuid: String, /// how many pending operations were processed pub processed: usize, /// how many of the pending operations matched the retry request pattern pub matched: u64, } ``` ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues Fixes hyperlane-xyz#4059 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing Updated unit tests to return a response so the handler is not blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a mpsc channel between relayer and message retry handler, so message retry handler knows the retry results from the relayer.
POST /message_retryendpoint now returns a JSON with details on the retry request:Drive-by changes
Related issues
Fixes #4059
Backward compatibility
Testing
Updated unit tests to return a response so the handler is not blocked