Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark fix of fisco-bcos sample #260

Closed

Conversation

kartikaysaxena
Copy link

@kartikaysaxena kartikaysaxena commented Apr 10, 2024

Fixes #170

@kartikaysaxena kartikaysaxena requested a review from a team April 10, 2024 22:17
@kartikaysaxena
Copy link
Author

PTAL @davidkel

@@ -2,25 +2,24 @@ test:
name: Hello World
description: This is a helloworld benchmark of FISCO BCOS for caliper
workers:
type: local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type local isn't a recognised option any more, so need to add this line in.

@@ -2,27 +2,26 @@ test:
name: Solidity Transfer
description: This is a solidity transfer benchmark of FISCO BCOS for caliper
workers:
type: local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type local isn't a recognised option any more, so need to add this line in.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of minor comments, all the other changes look reasonable

@davidkel
Copy link
Contributor

davidkel commented May 1, 2024

Closing as we have now removed fisco-bcos and created tags for 0.5.0 which is the last version to contain fisco-bcos and this PR was not updated in time as we needed to get a new release of caliper out.

@davidkel davidkel closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fisco-bcos benchmarks fail to work due to incorrect benchmark format
2 participants