-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark fix of fisco-bcos sample #260
Benchmark fix of fisco-bcos sample #260
Conversation
Signed-off-by: Kartikay <[email protected]>
PTAL @davidkel |
@@ -2,25 +2,24 @@ test: | |||
name: Hello World | |||
description: This is a helloworld benchmark of FISCO BCOS for caliper | |||
workers: | |||
type: local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type local isn't a recognised option any more, so need to add this line in.
@@ -2,27 +2,26 @@ test: | |||
name: Solidity Transfer | |||
description: This is a solidity transfer benchmark of FISCO BCOS for caliper | |||
workers: | |||
type: local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type local isn't a recognised option any more, so need to add this line in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of minor comments, all the other changes look reasonable
Closing as we have now removed fisco-bcos and created tags for 0.5.0 which is the last version to contain fisco-bcos and this PR was not updated in time as we needed to get a new release of caliper out. |
Fixes #170