-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for internal-tx-observer module #1629
add test for internal-tx-observer module #1629
Conversation
b8efe76
to
840c90f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes here, Also I think this unit probably requires more tests.
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
840c90f
to
21dc162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You left a .only in
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
21dc162
to
780e2d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some real minor changes around the interval constant, then it should be good to go.
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/lib/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/lib/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
780e2d0
to
11ba2f3
Compare
packages/caliper-core/test/worker/tx-observers/internal-tx-observer.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You left a .only in
Signed-off-by: Babatunde Sanusi <[email protected]>
11ba2f3
to
25adf02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
Checklist
Issue/User story
Partially addresses #1606
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed
Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before
Automated Tests
What documentation has been provided for this pull request