Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for internal-tx-observer module #1629

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

tunedev
Copy link
Contributor

@tunedev tunedev commented Sep 11, 2024

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Partially addresses #1606

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed

  • caliper-core/lib/worker/tx-observers/internal-tx-observer.js: 100

Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before

  • caliper-core/lib/worker/tx-observers/internal-tx-observer.js: 26.08

Automated Tests

What documentation has been provided for this pull request

@tunedev tunedev requested a review from a team September 11, 2024 08:36
@tunedev tunedev force-pushed the test-internal-observer branch from b8efe76 to 840c90f Compare September 11, 2024 08:48
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes here, Also I think this unit probably requires more tests.

@tunedev tunedev force-pushed the test-internal-observer branch from 840c90f to 21dc162 Compare September 30, 2024 10:39
@tunedev tunedev requested a review from davidkel October 8, 2024 19:00
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left a .only in

@tunedev tunedev force-pushed the test-internal-observer branch from 21dc162 to 780e2d0 Compare November 6, 2024 10:49
@tunedev tunedev requested a review from davidkel November 6, 2024 10:49
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some real minor changes around the interval constant, then it should be good to go.

@tunedev tunedev force-pushed the test-internal-observer branch from 780e2d0 to 11ba2f3 Compare November 18, 2024 12:23
@tunedev tunedev requested a review from davidkel November 18, 2024 20:43
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left a .only in

@tunedev tunedev force-pushed the test-internal-observer branch from 11ba2f3 to 25adf02 Compare November 20, 2024 07:07
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@davidkel davidkel merged commit 3661a0e into hyperledger-caliper:main Nov 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants