Add back in validation for negative chainId

Signed-off-by: Simon Dudley <[email protected]>
hyperledger · Jan 14, 2025 · 910ef3f · 910ef3f
1 parent 58f52fa
commit 910ef3f
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/json/ChainIdDeserializer.java b/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/json/ChainIdDeserializer.java
@@ -35,7 +35,12 @@ public ChainIdDeserializer(final Class<?> vc) {
   @Override
   public BigInteger deserialize(final JsonParser jsonparser, final DeserializationContext context)
       throws IOException {
-    return UInt256.fromHexString(jsonparser.getCodec().readValue(jsonparser, String.class))
-        .toBigInteger();
+    final var chainId =
+        UInt256.fromHexString(jsonparser.getCodec().readValue(jsonparser, String.class))
+            .toBigInteger();
+    if (chainId.signum() < 0) {
+      throw new IllegalArgumentException("Negative chain id: " + chainId);
+    }
+    return chainId;
   }
 }