add fallback for parallelization #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <[email protected]>
ahamlat
approved these changes
Jan 9, 2025
| ParallelizedConcurrentTransactionProcessor parallelizedConcurrentTransactionProcessor = | ||
| new ParallelizedConcurrentTransactionProcessor(transactionProcessor); | ||
| // runAsyncBlock, if activated, facilitates the non-blocking parallel execution of | ||
| // transactions in the background through an optimistic strategy. |
There was a problem hiding this comment.
Suggesting the following comment instead, as 'non-blocking' could have a different meaning : When enabled, runAsyncBlock performs non-conflicting parallel execution of transactions in the background using an optimistic approach.
garyschulte
reviewed
Jan 9, 2025
| if (blockProcessingResult.isFailed()) { | ||
| // Fallback to non-parallel processing if there is a block processing exception . | ||
| LOG.info( | ||
| "Block processing failed. Falling back to non-parallel processing for block #{} ({})", |
There was a problem hiding this comment.
Perhaps change this log to "Parallel transaction processing failure. Falling... ". Just to be more clear in the log output.
garyschulte
reviewed
Jan 9, 2025
| @@ -1816,10 +1816,8 @@ public BesuControllerBuilder setupControllerBuilder() { | |||
| if (DataStorageFormat.BONSAI.equals(getDataStorageConfiguration().getDataStorageFormat())) { | |||
| final DiffBasedSubStorageConfiguration subStorageConfiguration = | |||
| getDataStorageConfiguration().getDiffBasedSubStorageConfiguration(); | |||
| if (subStorageConfiguration.getLimitTrieLogsEnabled()) { | |||
There was a problem hiding this comment.
was this a git merge thing? odd that we were gating parallel tx on trielog pruning
There was a problem hiding this comment.
it's a bug I found so I removed this invalid check
garyschulte
approved these changes
Jan 9, 2025
| final List<BlockHeader> ommers, | ||
| final Optional<List<Withdrawal>> maybeWithdrawals, | ||
| final PrivateMetadataUpdater privateMetadataUpdater, | ||
| final PreprocessingFunction preprocessingBlockFunction) { |
Signed-off-by: Karim Taam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This pull request introduces a fallback mechanism that go back to non-parallelization if a problem is detected during parallel execution. This is a mitigation measure to address the issue while a permanent fix is being developed and will be delivered in a subsequent PR.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests