Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guess type for delegate code transactions #8090

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Fix guess type for delegate code transactions #8090

merged 4 commits into from
Jan 9, 2025

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Since DELEGATE_CODE transactions have maxFeePerGas and accessList, the check for codeDelegationAuthorizations needs to come first; otherwise, we get the wrong type.

@Gabriel-Trintinalia Gabriel-Trintinalia added bug Something isn't working mainnet labels Jan 9, 2025
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title Fix guess type for code delegation transactions Fix guess type for delegate code transactions Jan 9, 2025
usmansaleem
usmansaleem approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

usmansaleem
usmansaleem approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 8448743 into hyperledger:main Jan 9, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

@daniellehrner daniellehrner Awaiting requested review from daniellehrner

Assignees
No one assigned
Labels
bug Something isn't working mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriel-Trintinalia @usmansaleem