Pass miningBeneficiary address to BlockAwareOperationTracer::traceStartBlock calls #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pinto
force-pushed
the
add-miner-address-tracer-API
branch
2 times, most recently
from
bf28c88 to
6710f5f
Compare
Gabriel-Trintinalia
requested changes
Jan 10, 2025
| @@ -191,7 +191,7 @@ private List<TransactionProcessingResult> trace( | |||
| final ProtocolSpec protocolSpec = protocolSchedule.getByBlockHeader(block.getHeader()); | |||
| final MainnetTransactionProcessor transactionProcessor = protocolSpec.getTransactionProcessor(); | |||
| final BlockHeader header = block.getHeader(); | |||
| tracer.traceStartBlock(block.getHeader(), block.getBody()); | |||
| tracer.traceStartBlock(block.getHeader(), block.getBody(), block.getHeader().getCoinbase()); | |||
There was a problem hiding this comment.
You will need to use miningBeneficiaryCalculator here otherwise the coinbase will still be zero for Click
lu-pinto
force-pushed
the
add-miner-address-tracer-API
branch
from
6710f5f to
6097d0b
Compare
Gabriel-Trintinalia
approved these changes
Jan 10, 2025
lu-pinto
force-pushed
the
add-miner-address-tracer-API
branch
from
6097d0b to
2564b7d
Compare
…rtBlock calls Signed-off-by: Luis Pinto <[email protected]>
lu-pinto
force-pushed
the
add-miner-address-tracer-API
branch
from
2564b7d to
bc0538c
Compare
fab-10
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Would have been great to keep the previous methods signature (marking them deprecated for removal) so existing plugins will not break.
Since this is already merged, that can be done in a following PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This passes the miningBeneficiary, which in most cases should be the coinbase but for other consensus approaches could be different, to BlockAwareOperationTracer::traceStartBlock calls.
Fixed Issue(s)
fixes #8094
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests