Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes and improvements Update besu-entry.sh #8107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

annwag
Copy link

@annwag annwag commented Jan 12, 2025

PR description

I’ve made several updates to address issues and improve the script’s reliability, readability, and maintainability.

Here’s a summary of the changes:

  1. Explicit Exit for Non-Root Users: Added exit 0 after exec to ensure the script terminates immediately, preventing unintended behavior.
  2. Variable Validation: Added a check for BESU_USER_NAME to avoid errors from undefined variables.
  3. Error Handling: Improved error handling for the besu --print-paths-and-exit command to fail early if the command fails.
  4. Output Parsing: Replaced IFS=: with cut to correctly handle paths with spaces or special characters.
  5. Quoted Variables: Wrapped variables in quotes to prevent issues with paths containing spaces or special characters.
  6. Logging: Added echo statements for better debugging and progress tracking.
  7. Readability: Added comments and restructured the code for clarity and easier maintenance.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant