feat: cyclenext, visible parameter #9045
Conversation
sounds great, I'll make some edits |
Truenya
changed the title
|
@vaxerski that way - done I'm rereading it and thinking that maybe it would be better to make this behavior the default, and make the workspace cycle optional, and change the function names? |
| if (w != pWindow && w->m_pWorkspace == pWindow->m_pWorkspace && w->m_bIsMapped && !w->isHidden() && (!focusableOnly || !w->m_sWindowData.noFocus.valueOrDefault())) | ||
| return w; | ||
| } | ||
| inline static bool isWorkspaceMatches(PHLWINDOW pWindow, const PHLWINDOW w, bool anyWorkspace) { |
There was a problem hiding this comment.
wtf does isWorkspaceMatches mean? xD
windowAvailableForCycle? or what?
There was a problem hiding this comment.
isWindowAvailableForCycle is a little bit lower, this is the part of it, isWorkspaceMatches means window availability checks for cycle, related to workspace
There was a problem hiding this comment.
isWorkspaceMatches is such a confusing name I still don't understand what it's actually doing
There was a problem hiding this comment.
Checks workspace for cyclenext.
When visible parameter is passed, checks is workspace visible, otherwise checks is workspace same as current
Describe your PR, what does it fix/add?
#6678
cyclenext, visibleshoud works as cyclenext, but also cycling other monitor windowsIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
nothing
Is it ready for merging, or does it need work?
ready for merging