Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
To make it possible to save and restore dwindle workspace layouts via hyprctl.
To be able to "restore" layouts it adds an
"opennexton"
layoutmsg handler for the dwindle layout. It works like"preselect"
but with a dwindle node instead."Saving" layouts is done with
hyprctl layoutdata workspaceinfo <workspace_id>
.The hyprctl cmd (
"layoutdata"
) which kind of does the same thing as"dispatch layoutmsg"
but allows the layout to send a response.workspaceinfo
is then a handler implemented for the dwindle layout.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Some points which need to be discussed:
opennexton
layoutmsg handler may not be particularly intuitive. I think there should be a way to target nodes which contain more than one window. And targeting the root is really useful if you want to do something like "maximize to half the screen". But it may be better to just leave out that functionality for now."setnodesplitratio"
layoutmsg handler is also needed if you want to restore the window sizes of the layout. I thoughtdispatch splitratio
could be used it does not take a window argument. And even if it did there would be no way to target nodes which are not single windows.Is it ready for merging, or does it need work?
NO, the questions above need to be addressed first. But aside from that there is also the documentation and stuff like tab completions for hyprctl.