Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSX key attribute clobbering detected value #1042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Fix JSX key attribute clobbering detected value #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lexers/jsx-lexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default class JsxLexer extends JavascriptLexer {
'i',
'p',
]
this.omitAttributes = [this.attr, 'ns', 'defaults']
this.omitAttributes = [this.attr, 'ns', 'key', 'defaults']
this.transIdentityFunctionsToIgnore =
options.transIdentityFunctionsToIgnore || []
}
Expand Down
10 changes: 10 additions & 0 deletions test/lexers/jsx-lexer.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,16 @@ describe('JsxLexer', () => {
done()
})

it('ignores the protected React key attribute when defined', (done) => {
const Lexer = new JsxLexer()
const content =
'<Trans key="foo" i18nKey="first" count={count}>Yo</Trans>'
assert.deepEqual(Lexer.extract(content), [
{ key: 'first', defaultValue: 'Yo', count: '{count}' },
])
done()
})

it('extracts default value from string literal `defaults` prop', (done) => {
const Lexer = new JsxLexer()
const content =
Expand Down