-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/help command #30
Conversation
- 'help' command was crashing because intents.guilds was not enabled
…to before_invoke decorator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great! Just a few question but you did a great job actually!!
Thanks for rewriting the craft_intents
fucntion it was a mess ahah
and the commands desc looks great too!
Thanks for your review ! Feel free to ask some features you would like to see in the custom help command ! I add the strict minimum right now ! |
I couldn't get a perfect pylint as it misses the fact I am implementing correctly the methods of the HelpCommand class. I looked at the source code to be sure. This is why, I tried to look at a similar issue and it turns out there is an issue on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a long time ago so I may have missed some caveats but seems ready to me!
Problem is that you won't be able to merge the PR if pylint doesn't pass...
hmm the issue is closed don't know if it should be solved or not to be honest |
once @J3y0 will have resolved/answered the last thread we'll be able to merge this! |
This PR solves #15 issue.
Problem was the bot didn't have the guild intent which is necessary for the
help
command (didn't find it on the internet so I did find it by trying repeatedly with different intents...).This PR brings:
craft_intent
function where intents accorded to the bot are clearly stated (it was impossible for me to understand what intents were linked to the value passed in argument to theIntent()
constructor.discord
library. It is very simple for now and has to be considered as a base for future and more complex implementation.Bot()
constructor, thehelp
command was not in theCOG
and couldn't be subject to logging with thebefore_invoke
decorator. This is why, I added logging into theon_command
event. Then, logging is automatically done when a command is triggered