-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect files that don't need to be linted in no-internal #40
Draft
MichaelBelousov
wants to merge
30
commits into
main
Choose a base branch
from
filter-no-internal-lint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBelousov
changed the title
Filter no internal lint
detect files that don't need to be linted in no-internal
Jul 27, 2023
…orkspace-tools dep
MichaelBelousov
requested review from
paulius-valiunas,
ben-polinsky and
aruniverse
as code owners
July 28, 2023 18:02
found some issues, redrafting to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In workspaces or general linting of large amounts of code which do not always use @itwin/@bentley packages, it is possible to avoid expensively checking every identifier by first determining whether the file is in a package with dependencies that we want to check for
@internal
APIs at all. Hide it behind an "experimental" optionIn a local project this provided me a 33% speed up in a particular build pipeline