Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect files that don't need to be linted in no-internal #40

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

MichaelBelousov
Copy link
Contributor

@MichaelBelousov MichaelBelousov commented Jul 27, 2023

In workspaces or general linting of large amounts of code which do not always use @itwin/@bentley packages, it is possible to avoid expensively checking every identifier by first determining whether the file is in a package with dependencies that we want to check for @internal APIs at all. Hide it behind an "experimental" option

In a local project this provided me a 33% speed up in a particular build pipeline

  • fix utility that adds skip/only utility to tests
  • remove workspace-tools dep and just manually hunt for the package.json since I need the same thing but working without workspaces
  • fix issue where link fixtures script fails on second run

@MichaelBelousov MichaelBelousov changed the title Filter no internal lint detect files that don't need to be linted in no-internal Jul 27, 2023
@MichaelBelousov MichaelBelousov marked this pull request as ready for review July 28, 2023 18:02
@MichaelBelousov MichaelBelousov marked this pull request as draft July 28, 2023 19:30
@MichaelBelousov
Copy link
Contributor Author

found some issues, redrafting to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants