Presentation: Fix Presentation RPC returning details contained within thrown errors #7560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons we don't want the backend's error response to contain any details about the error. The RPC implementation was converting all errors to a 200 response containing the error message. Now we only do that for
PresentationError
errors, which contain errors that we want to return (e.g. "invalid element id", or "unknown presentation rule", etc.). The genericError
errors are just re-thrown to the RPC system, where they can be handled in a generic way.