Skip to content

Commit

Permalink
Hierarchies: Fix hierarchy filtering (#720)
Browse files Browse the repository at this point in the history
  • Loading branch information
grigasp authored Oct 4, 2024
1 parent 9944106 commit e732356
Show file tree
Hide file tree
Showing 5 changed files with 271 additions and 56 deletions.
9 changes: 9 additions & 0 deletions .changeset/gorgeous-dingos-clap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@itwin/presentation-hierarchies": patch
---

Fixed iModel hierarchy provider returning unfiltered nodes after setting the hierarchy filter in certain scenarios.

The situation could happen when a new hierarchy filter is set during an ongoing nodes request. Then, requesting nodes immediately after setting the filter could return nodes from the previous request.

The change also slightly changes what happens with ongoing requests when hierarchy provider's internal state is reset: provider is disposed, the `imodelChanged` event is raised or hierarchy filter is set. Previously, it would continue handling all ongoing requests and return a valid result. Now, it will stop ASAP and return an empty list.
Loading

0 comments on commit e732356

Please sign in to comment.