-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defensive checks for ml labels in config #20
Merged
Merged
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
89d1087
WIP-ADD: adding the label check
sushidelivery 5f270fe
UPDATE: updated the existing code for label check
sushidelivery f806674
ADD-WIP: added acit files check
sushidelivery 6d123a7
UPDATE: updated the check acit files
sushidelivery e65b13b
ADD: added check acit files into ttool constructor
sushidelivery 36e1f86
REFACTOR: changed the format of label map and renamed it
sushidelivery a1103be
ADD: added classifier cmake for labels
sushidelivery ce6a304
ADD: added python script to load the labels to config
sushidelivery 96611d4
ADD: added classifier label file path
sushidelivery 86423b4
REMOVE: removed the label map file
sushidelivery 8140046
REFACTOR: updated the label
sushidelivery 337ccfb
ADD: added the success log
sushidelivery 011bc63
FIX: fixed the indentation
sushidelivery 60386ab
FIX: fixed the config file indentation
sushidelivery 15d4235
FIX: fixed the label
sushidelivery 5210283
FIX: fixed the indentation for labels
sushidelivery 344160c
FIX: set zenodo dataset bleeding edge by default
9and3 3fb4404
UPDATE: moved the check function into initilize config
sushidelivery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I think
m_ConfigPtr->CheckAcitFiles(ttoolRootPath);
should not be exposed in the constructor.I propose simply to put it in the definition of
InitializeConfig(..)
function, in the samettool.hh
header. Here:https://github.com/ibois-epfl/TTool/blob/6e19a12bcba18326c3bfa8cd76d3e66bd2c27488/include/ttool.hh#L433C9-L438C10
Let me know if it works, and give it a go on a compiled AC just to be 100% sure that there are no problems.