Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API interface for AC headless test #23

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Update API interface for AC headless test #23

merged 2 commits into from
Oct 25, 2024

Conversation

Petingo
Copy link
Collaborator

@Petingo Petingo commented Oct 16, 2024

Description 🤖

A flag is added to the constructor for enabling/disabling the visualization feature.

Type of feature/changes 🌲

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

9and3
9and3 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I am merging this one HB since it shouldn't break the main given that the added parameters has a default value. Thanks!

@9and3 9and3 marked this pull request as ready for review October 25, 2024 09:39
@9and3 9and3 merged commit 41d536c into main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9and3 9and3 9and3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Petingo @9and3