-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#130 custom enum field #147
Feature/#130 custom enum field #147
Conversation
Tested this:
and it gave me this:
|
rename |
} | ||
|
||
final deprecatedGenerateMap = value['generate_map']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this deprecated? Because the map is still needed. but it should use the values fields from the enum values instead. Otherwise we will have to write our own mapping each time we want to map something. Keeping this logic will make it the same for all projects
Fix/issues
There is an issue with the lowercasing in enum names inBrowser:
properties:
value: inBrowser @JsonValue('inBrowser')
inbrowser(
value: 'inBrowser',
); I would expect inbrowser to still have a capital B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment in conversation
fixes #130