Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add warning color to palette #2607

Merged
merged 10 commits into from
Jan 6, 2025
Merged

Conversation

DavidAguilo
Copy link
Contributor

I have added a warning field to the palette since I have found myself needing one. It uses yellow, unless otherwise specified by the theme page.

@DavidAguilo DavidAguilo changed the title Add warning color to palette Feat: Add warning color to palette Sep 25, 2024
Copy link
Contributor

@tvolk131 tvolk131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a nitpick, but it might make more sense to have warning be listed between success and danger rather than after danger. Otherwise LGTM!

@DavidAguilo
Copy link
Contributor Author

You are right, it makes more sense. I've made the commit to move warning lines to be between success and danger.

Copy link
Contributor

@tvolk131 tvolk131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hecrj hecrj added this to the 0.14 milestone Jan 6, 2025
@hecrj hecrj added feature New feature or request styling addition labels Jan 6, 2025
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! I've been feeling like the built-in palette is quite limited for a while.

Thanks!

@hecrj hecrj enabled auto-merge January 6, 2025 20:07
@hecrj hecrj merged commit b156087 into iced-rs:master Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition feature New feature or request styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants