Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dark-light to v2 #2724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade dark-light to v2 #2724

wants to merge 2 commits into from

Conversation

Rudxain
Copy link

@Rudxain Rudxain commented Jan 9, 2025


  • This is only a breaking change due to the version bump, the actual Iced-API is intact.
  • I haven't cargo checked, as the repo is too big to git clone (for me). I know I could download without the git log data, but I don't have much time now.
  • I formatted the code on the Rust playground

@Rudxain Rudxain marked this pull request as draft January 10, 2025 00:05
@Rudxain Rudxain changed the title Upgrade dark-light to 2.0 Upgrade dark-light to v2 Jan 10, 2025
@Rudxain Rudxain marked this pull request as ready for review January 10, 2025 00:09
@edwloef
Copy link
Contributor

edwloef commented Jan 10, 2025

cargo check, cargo fmt --all -- --check and the tour example run through fine, clippy complains about something but it's unrelated to this pr. This transitively updates zbus to v5 which is definitely nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants