Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compiletime derivatives #29666

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Jan 8, 2025

Reason

Eventually I'd like to allow more types and derivatives w.r.t more types (vectors, tensors) in this system, so I'm tring to make the typing more flexible

Design

Use auto more for result types. Make use of std::declval where appropriate.

Impact

Improved code.

@dschwen dschwen force-pushed the compiletime_derivatives_refactor branch from fd40509 to b30130d Compare January 9, 2025 21:27
dschwen added a commit to dschwen/moose that referenced this pull request Jan 9, 2025
dschwen added a commit to dschwen/moose that referenced this pull request Jan 9, 2025
@dschwen dschwen force-pushed the compiletime_derivatives_refactor branch from b30130d to b632730 Compare January 9, 2025 22:27
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on b632730 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29666/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format e193a3d452b52030c368f8b0e4cb692ef0113925

@dschwen dschwen force-pushed the compiletime_derivatives_refactor branch from b632730 to b0390b0 Compare January 15, 2025 13:18
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on b0390b0 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on b0390b0 wanted to post the following:

Framework coverage

2df091 #29666 b0390b
Total Total +/- New
Rate 85.25% 85.25% -0.00% 100.00%
Hits 108039 108042 +3 24
Misses 18699 18700 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants