Removed redeclaration of _name attribute from MooseApp #29671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MooseApp is derived from MooseBase. MooseBase has an attribute called _name, which described the name of the object. MooseApp erroneously redeclares this attribute and does not initialize it. Thus, when a MooseApp or more derived class tries to access _name, it defaults to the empty MooseApp::_name instead of the desired MooseBase::_name. MooseBase::_name is still accessible without using the namespace operator through the name() method because the name() method is not erroneously redeclare in MooseApp. This commit removes the erroneous redeclaration of MooseApp::_name. Ref idaholab#29670.
loganharbour
approved these changes
Jan 9, 2025
Closed
pbehne
changed the title
|
Job Documentation, step Docs: sync website on 00a3293 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 00a3293 wanted to post the following: Framework coverageCoverage did not change Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MooseApp is derived from MooseBase. MooseBase has an attribute called _name, which described the name of the object. MooseApp erroneously redeclares this attribute and does not initialize it. Thus, when a MooseApp or more derived class tries to access _name, it defaults to the empty MooseApp::_name instead of the desired MooseBase::_name. MooseBase::_name is still accessible without using the namespace operator through the name() method because the name() method is not erroneously redeclare in MooseApp. This commit removes the erroneous redeclaration of MooseApp::_name. Closes #29670.