feat!: raise TypeError if config field does not match declared type #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently field values are parsed even if their type doesn't match the field's declared type. This avoids errors, but doesn't allow correct parsing of union type fields (e.g.
list[str] | list[list[str]]
) which would rely on mismatched values to be rejected.This PR enforces stricter parsing, thus allowing correct parsing of union type fields. It reveals some incorrectly declared types in Coqui configs, e.g.
steps_to_start_discriminator: bool = 200000
that will be fixed in a PR before switching to the new Coqpit version. This results in some configs of pretrained models now having mismatched values, e.g."steps_to_start_discriminator": true,
invocoder_models/en/ljspeech/multiband-melgan
. Coqpit now recognises these mismatches and replaces the value with the field's default value, emitting a warning on the first use:This ensures that all pretrained Coqui models can still be used as is (https://github.com/idiap/coqui-ai-TTS/actions/runs/12724541599).