Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Replace dyn Trait with Enum for Encryptor and Persister Types #1442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haze518
Copy link
Collaborator

@haze518 haze518 commented Jan 16, 2025

Addresses part of ##667

This PR refactors the codebase to replace the use of dyn Trait for Encryptor and Persister with enum types (EncryptorKind and PersisterKind)

@haze518 haze518 requested review from numinnex and hubcio January 16, 2025 02:03
@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12804200288

Details

  • 41 of 60 (68.33%) changed or added relevant lines in 16 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 75.432%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/src/main.rs 2 3 66.67%
sdk/src/clients/builder.rs 0 1 0.0%
server/src/streaming/segments/storage.rs 1 2 50.0%
server/src/streaming/storage.rs 2 3 66.67%
sdk/src/clients/consumer.rs 0 2 0.0%
sdk/src/clients/producer.rs 0 3 0.0%
server/src/streaming/systems/system.rs 4 7 57.14%
server/src/streaming/persistence/persister.rs 12 19 63.16%
Files with Coverage Reduction New Missed Lines %
sdk/src/utils/crypto.rs 1 88.06%
Totals Coverage Status
Change from base Build 12770513340: 0.03%
Covered Lines: 24648
Relevant Lines: 32676

💛 - Coveralls

@haze518 haze518 force-pushed the use-less-dyn branch 3 times, most recently from 1c23f04 to 46a5217 Compare January 16, 2025 07:36
piotr-laserdata

This comment was marked as off-topic.

Copy link
Collaborator

@spetz spetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please do the following before the final approval:

  • Update to the latest commit
  • Bump server version to 0.4.120
  • Bump SDK version to 0.6.80

Make sure that everything compiles correctly and push the changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants