-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Westeros tutorials and adding new ones #232
Conversation
baa0e62
to
1c41ea8
Compare
c7e65a7
to
0035fa6
Compare
cb2314f
to
a8902cd
Compare
a8902cd
to
a36ac90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @behnam-zakeri for these improvements to the existing tutorials and the new one, which sets a high standard for clarity that I think learners will appreciate. I added some minor comments inline.
One additional change I spotted in westeros_baseline.ipynb that is not part of a line you changed: “The full framework documentation is available at https://messageix.iiasa.ac.at” — should be https://message.iiasa.ac.at.
49a82a7
to
fd62ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @khaeru for a thorough review and constructive feedback. I applied the changes you mentioned.
fd62ceb
to
6731d75
Compare
6731d75
to
4e6c6de
Compare
Thanks @khaeru for noticing this. Corrected. |
4e6c6de
to
41c10cc
Compare
Okay, will merge this now. As discussed in today's MESSAGE meeting, the following PRs made were made against the
|
Thanks @behnam-zakeri! |
This PR updates the existing Westeros tutorials and adds a new tutorial for improving the learning experience of the users.
This PR does the following:
Doesn't need a test and documentation
Release notes updated.