Skip to content

Address review comments

Codecov / codecov/project failed Jan 9, 2025 in 0s

24.0% (-71.7%) compared to a60715a

View this Pull Request on Codecov

24.0% (-71.7%) compared to a60715a

Details

Codecov Report

Attention: Patch coverage is 29.41176% with 36 lines in your changes missing coverage. Please review.

Project coverage is 24.0%. Comparing base (a60715a) to head (0820703).

Current head 0820703 differs from pull request most recent head 9926003

Please upload reports for the commit 9926003 to get more accurate results.

Files with missing lines Patch % Lines
message_ix/report/__init__.py 7.1% 13 Missing ⚠️
message_ix/tools/sankey.py 47.3% 10 Missing ⚠️
message_ix/tests/tools/test_sankey.py 33.3% 8 Missing ⚠️
message_ix/tests/test_report.py 16.6% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a60715a) and HEAD (0820703). Click for more details.

HEAD has 33 uploads less than BASE
Flag BASE (a60715a) HEAD (0820703)
36 3
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #770      +/-   ##
========================================
- Coverage   95.6%   24.0%   -71.7%     
========================================
  Files         46      48       +2     
  Lines       4338    4389      +51     
========================================
- Hits        4148    1054    -3094     
- Misses       190    3335    +3145     
Files with missing lines Coverage Δ
message_ix/tests/test_tutorials.py 97.6% <ø> (ø)
message_ix/tests/test_report.py 19.6% <16.6%> (-80.4%) ⬇️
message_ix/tests/tools/test_sankey.py 33.3% <33.3%> (ø)
message_ix/tools/sankey.py 47.3% <47.3%> (ø)
message_ix/report/__init__.py 38.0% <7.1%> (-62.0%) ⬇️

... and 41 files with indirect coverage changes