Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8 formatted the output of cpu-temperature script #18

Closed
wants to merge 1 commit into from

Conversation

Sidharth-Singh10
Copy link

This pull request updates the output format of temperature values from milli-celsius to Celsius and Fahrenheit.
With this change, the temperature values are converted to Celsius and Fahrenheit, providing a more intuitive and user-friendly output format.

Changes Made:

  1. Updated the conversion logic to calculate temperature values in Celsius and Fahrenheit.
  2. Updated the output format to display temperature values in Celsius and Fahrenheit.

@ecxtacy
Copy link

ecxtacy commented Mar 15, 2024

Hi @Sidharth-Singh10, thanks for putting up the PR.
It's a good practice to use proper capitalisation in the PR heading and also try to include screenshots of the output.

@ecxtacy
Copy link

ecxtacy commented Mar 15, 2024

No need of mentioning #8 in the PR heading, rather include a Fixes #issue_number in the PR description.

@rootCircle
Copy link
Member

Hi @Sidharth-Singh10, congrats on your first contribution to this repo!

Please try to add screenshots/video while making a PR as a good practice!

Code works great! LGTM

@rootCircle
Copy link
Member

fixes #8
accepted 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants