fix: parameter is iterable

ilteoood · Jan 11, 2024 · 71bbd34 · 71bbd34
1 parent 19b2a1b
commit 71bbd34
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/fromIterable.ts b/src/fromIterable.ts
@@ -2,13 +2,19 @@ export const fromIterable = <T>(
 	sourceIterable: Iterable<T>,
 	strategy?: QueuingStrategy,
 ): ReadableStream<T> => {
+	if (!sourceIterable?.[Symbol.iterator]) {
+		throw new Error("sourceIterable is not iterable");
+	}
+	const iterator = sourceIterable[Symbol.iterator]();
 	return new ReadableStream<T>(
 		{
-			start(controller) {
-				for (const value of sourceIterable) {
+			pull(controller) {
+				const { value, done } = iterator.next();
+				if (done) {
+					controller.close();
+				} else {
 					controller.enqueue(value);
 				}
-				controller.close();
 			},
 		},
 		strategy,

diff --git a/test/fromIterable.test.ts b/test/fromIterable.test.ts
@@ -42,4 +42,9 @@ describe("fromIterable", () => {
 			"sourceIterable is not iterable",
 		);
 	});
+
+	it("should throw if parameter is iterable", () => {
+		// @ts-expect-error undefined parameter for test
+		expect(() => fromIterable(1)).toThrow("sourceIterable is not iterable");
+	});
 });