Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QElidingLabel instead of QLabel #314

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Use QElidingLabel instead of QLabel #314

merged 2 commits into from
Dec 19, 2024

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Nov 26, 2024

napari depends on superqt, so we are only adding a new dependency in writing.

Note that this will require the merge and release of pyapp-kit/superqt#260 to work properly

Closes #273

@gselzer gselzer added the enhancement New feature or request label Nov 26, 2024
@gselzer gselzer self-assigned this Nov 26, 2024
@gselzer
Copy link
Collaborator Author

gselzer commented Nov 26, 2024

@ctrueden suggested refactoring result_runner into a detail pane like that found in the Fiji search results. While I think it's a nice idea, it's beyond the scope of the issue this PR was designed to resolve. We should make another issue for it

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/25

@gselzer gselzer force-pushed the eliding-results branch 2 times, most recently from 6522602 to 3cace08 Compare December 17, 2024 17:36
@gselzer
Copy link
Collaborator Author

gselzer commented Dec 17, 2024

A new version of superqt was released on PyPI, would just be nice to get it on conda-forge as well (just need conda-forge/superqt-feedstock#35 merged)

napari depends on superqt, so we are only adding a new dependency in
writing
@gselzer gselzer force-pushed the eliding-results branch 2 times, most recently from 863e36d to fa54f20 Compare December 19, 2024 21:55
These methods were mucking with the child widget ordering. I have no
idea how they avoided deletion to this point!
@gselzer gselzer merged commit 5bb3441 into main Dec 19, 2024
14 checks passed
@gselzer gselzer deleted the eliding-results branch December 19, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

napari-imagej widget width grows wider when selecting op search results with long names
2 participants