-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: map RGBA8 internal format to RGBA texture format #29
Conversation
For Three's webgl2 it fix 'invalid format' but 'Draw framebuffer is incomplete is still thrown. for webgl1 three not use a layers context: https://github.com/mrdoob/three.js/blob/master/src/renderers/webxr/WebXRManager.js#L268 |
Thanks for taking the time to write this PR! When you say 'draw framebuffer is incomplete' is still thrown, is that with the changes in this PR? Do you have an example that I can run where the polyfill fails? I can take a better look at things that way. I'm also reviewing the code now, and will have comments on that shortly. |
I still can't figure out easy fix. Convert to draft. PR change a https://exponenta.github.io/web-xr-ogl-js/dist/ @dmliao topic is updated See: https://codesandbox.io/s/happy-raman-0zzmoo?file=/src/index.ts |
The internal format issue should be fixed with #34. However...the codesandbox is still producing incomplete framebuffers, and I haven't quite figured out why yet; my only thought right now is that #33 might be related, if the polyfill isn't giving a width and height for the projection layer to THREE.JS. I'll continue investigating. |
@dmliao Yep, invalid projection size is problem, then also needs reset frambuffer state of TheeJS too. https://github.com/abdullaBest/threejs-webxr-layers-polyfill/blob/main/public/js/render.js#L354 I think that this edge case needs to mark in readme. |
Fix for #24
Follow #27 #26
Fix is needs because a Three still use a rgba8 as target of projection layer, and in polyfill this is down.
https://github.com/mrdoob/three.js/blob/master/src/renderers/webxr/WebXRManager.js#L307
Issues demo:
https://0zzmoo.csb.app/
https://codesandbox.io/s/happy-raman-0zzmoo?file=/src/index.ts