Expose XRSession's granted features #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute to XRSession
|
I weighed adding a change event but opted not to at this time since we don't currently have any mechanisms/algorithm's/language about changing the set of enabled features mid session; but it should be fairly straightforward to add if we want to either pre-emptively add support, or if I just missed that. |
Manishearth
reviewed
Aug 16, 2022
Manishearth
approved these changes
Aug 17, 2022
toji
approved these changes
Aug 23, 2022
github-actions bot
added a commit
that referenced
this pull request
Aug 24, 2022
SHA: a493dd5 Reason: push, by @alcooper91 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 1, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 2, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 4, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 4, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
josephrocca
added a commit
to josephrocca/three.js
that referenced
this pull request
Mar 11, 2024
…sion.requestLightProbe` The double-negative here is unfortunate, but currently `session.enabledFeatures` is only available in Chromium-based browsers, so we can't always *positively* know that the feature is supported. Another approach would be to wrap `session.requestLightProbe` in try/catch, or add `.catch` after the `.then`, but for whatever reason, those don't seem to actually catch the error for me. Related: immersive-web/webxr#1296
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Issue #1205, this proposal makes the following changes:
enabledFeaturesNote that this second change is consistent with how feature descriptors have currently been extended by the various other specs. It essentially requires that we have a string representation of the feature and can then further configure the feature as needed.
Preview | Diff