feat(cli): watch paths for auto uploading daemon #14923
Conversation
eligao
force-pushed
the
feat/cli-watch-changes
branch
from
78824da to
32ba427
Compare
eligao
force-pushed
the
feat/cli-watch-changes
branch
from
c267202 to
3e74c98
Compare
| batchSize, | ||
| debounceTimeMs, | ||
| onBatch: async (paths: string[]) => { | ||
| const uniquePaths = [...new Set(paths)]; |
There was a problem hiding this comment.
When would these ever not be unique?
There was a problem hiding this comment.
chokidar.watchFs() can emit multiple events when a file is created/written/closed.
It is worked around with awaitWriteFinish but it's safer to double check here for duplication.
cli/src/commands/asset.ts
Outdated
| if (!extensions.has(ext ?? '')) { | ||
| return; | ||
| } | ||
| console.log(`Change detected: ${path}`); |
There was a problem hiding this comment.
How does this interact with the progress bar?
There was a problem hiding this comment.
good point, let me disable this log to prevent conflict when progress bar is enabled
| @@ -69,6 +69,13 @@ program | |||
| .default(4), | |||
| ) | |||
| .addOption(new Option('--delete', 'Delete local assets after upload').env('IMMICH_DELETE_ASSETS')) | |||
| .addOption(new Option('--no-progress', 'Hide progress bars').env('IMMICH_PROGRESS_BAR').default(true)) | |||
There was a problem hiding this comment.
Why is this hiding progress by default? The option and the env name are confusing me.
There was a problem hiding this comment.
this option starting with --no- is suitable for the option defaulting to true. The final parsed progress is not negated.
when running as a daemon, rendering a progress bar might flood the logs with duplicated progress bar re-renders, thus I imply progress to be false when watch is true below. progress is still true by default.
see: https://www.npmjs.com/package/commander#other-option-types-negatable-boolean-and-booleanvalue
Adds a
--watchflag to continue watching for changes after initial upload.immich upload ./assets/ --watch--watch, as it batch uploads all current items in one go.--no-progressflag to hide progress bars to make logs cleaner when running as a daemon--watchflag